Maintenance refactoring#7
Merged
akofink merged 1 commit intoOpenSCAP:masterfrom Aug 7, 2019
Merged
Conversation
Closed
xprazak2
force-pushed
the
refactor-parse
branch
from
09d9154 to
67255f2
Compare
akofink
reviewed
Aug 6, 2019
Collaborator
akofink
left a comment
akofink
left a comment
There was a problem hiding this comment.
Looks great! 👍 Just a couple comments.
Extracts rule results and test result into a separate concerns. Improves how newlines are removed from text.
xprazak2
force-pushed
the
refactor-parse
branch
from
67255f2 to
9a83043
Compare
Collaborator
Author
|
Updated with suggested changes. |
akofink
approved these changes
Aug 7, 2019
| def identifier | ||
| @identifier ||= { | ||
| label: @rule_xml.at_css('ident')&.text, | ||
| label: @rule_xml.at_css('ident') && @rule_xml.at_css('ident').text, |
Collaborator
There was a problem hiding this comment.
Why this change? You don't like the new &. syntax?
Contributor
There was a problem hiding this comment.
Perhaps the proxy has to run on an older version of ruby...?
Collaborator
There was a problem hiding this comment.
Yeah - I'm not blocking this PR on it, just curious.
Collaborator
Author
There was a problem hiding this comment.
Exactly, proxies may have older versions of ruby.
Collaborator
|
Closing and reopening to trigger tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts rule results and test result
into a separate concenrns.
Improves how newlines are removed from text.